Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#2292 Fix: deleted messages are still visible in thread #2297

Merged
merged 2 commits into from
Jul 26, 2023
Merged

#2292 Fix: deleted messages are still visible in thread #2297

merged 2 commits into from
Jul 26, 2023

Conversation

ioanmo226
Copy link
Collaborator

@ioanmo226 ioanmo226 commented Jul 26, 2023 •
edited by sosnovsky
Loading

This PR fixed deleted messages still visible in thread issue

close #2292 // if this PR closes an issue

Tests (delete all except exactly one):

  • Manually tested

To be filled by reviewers

I have reviewed that this PR... (tick whichever items you personally focused on during this review):

  • addresses the issue it closes (if any)
  • code is readable and understandable
  • is accompanied with tests, or tests are not needed
  • is free of vulnerabilities
  • is documented clearly and usefully, or doesn't need documentation

@ioanmo226 ioanmo226 marked this pull request as ready for review July 26, 2023 07:16
sosnovsky
sosnovsky approved these changes Jul 26, 2023
View reviewed changes
Copy link
Collaborator

@sosnovsky sosnovsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works well now 👍

@sosnovsky sosnovsky merged commit af025fe into master Jul 26, 2023
5 checks passed
@sosnovsky sosnovsky deleted the 2292-deleted-messages-are-still-visible-in-thread branch July 26, 2023 09:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sosnovsky sosnovsky sosnovsky approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Deleted messages are still visible in thread
2 participants
@ioanmo226 @sosnovsky